Skip to content

fix: TT-203 Customers Page: review the actions to ResetProjectToEdit … #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2021
Merged

fix: TT-203 Customers Page: review the actions to ResetProjectToEdit … #659

merged 2 commits into from
Apr 8, 2021

Conversation

@LEON12699
Copy link
Member

@LEON12699 LEON12699 commented Apr 6, 2021

  • ProjectType form and Project Form reset when discard the changes in the modal to alert "You have changes "

@codecov
Copy link

codecov bot commented Apr 6, 2021 •
edited
Loading

Codecov Report

Merging #659 (d260bb0) into master (13de42e) will increase coverage by 1.09%.
The diff coverage is 96.31%.

❗ Current head d260bb0 differs from pull request most recent head 2706a52. Consider uploading reports for the commit 2706a52 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage   93.09%   94.19%   +1.09%     
==========================================
  Files          85      101      +16     
  Lines        1564     1929     +365     
  Branches      107      130      +23     
==========================================
+ Hits         1456     1817     +361     
- Misses         67       75       +8     
+ Partials       41       37       -4
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 71.42% <71.42%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 83.33% <91.66%> (+0.98%) ⬆️
...ponents/details-fields/details-fields.component.ts 93.54% <94.44%> (+6.36%) ⬆️
src/app/modules/users/store/user.reducers.ts 96.55% <96.55%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a40635...2706a52. Read the comment docs.

scastillo-jp
scastillo-jp reviewed Apr 6, 2021
View reviewed changes
...omponents/projects-type/components/create-project-type/create-project-type.component.spec.ts Outdated
expect(store.dispatch).toHaveBeenCalledWith(new CreateProjectType(projectTypeData));
});

it('should reset Project Type Form if projectTypeIdToEdit is null', () => {
Copy link
Collaborator

@scastillo-jp scastillo-jp Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change Project Type Form to projectTypeForm

@LEON12699 LEON12699 requested a review from scastillo-jp April 7, 2021 19:31
@scastillo-jp scastillo-jp merged commit e5c051d into master Apr 8, 2021
@scastillo-jp scastillo-jp deleted the TT-203-Customers-Page-review-actions-ResetProjectEdit branch April 8, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scastillo-jp scastillo-jp scastillo-jp approved these changes

@eduardisrael eduardisrael Awaiting requested review from eduardisrael

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LEON12699 @scastillo-jp